[webkit-reviews] review denied: [Bug 108541] [chromium-android] disable WebKit-side scrollbar rendering : [Attachment 186196] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 1 17:43:31 PST 2013
James Robinson <jamesr at chromium.org> has denied Tien-Ren Chen
<trchen at chromium.org>'s request for review:
Bug 108541: [chromium-android] disable WebKit-side scrollbar rendering
https://bugs.webkit.org/show_bug.cgi?id=108541
Attachment 186196: Patch
https://bugs.webkit.org/attachment.cgi?id=186196&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186196&action=review
> Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp:106
> +#if 0
just delete it, don't #if 0. The code will live on in the revision tracking
system when/if we want to revive it
> Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp:148
> + // FIXME: We're hardcoding scrollbars in the compositor until
smoothiness issue getting solved.
smoothiness isn't a word, and this doesn't explain very well why we're doing
nothing
> Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp:151
> + (void)context;
> + (void)scrollbar;
> + (void)rect;
The way in WebKit to deal with unused parameters is to not give them a name.
More information about the webkit-reviews
mailing list