[webkit-reviews] review denied: [Bug 108678] [BlackBerry]Adjust fatfinger detection rect size : [Attachment 186116] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 1 14:47:51 PST 2013


Antonio Gomes <tonikitoo at webkit.org> has denied Tiancheng Jiang
<tijiang at rim.com>'s request for review:
Bug 108678: [BlackBerry]Adjust fatfinger detection rect size
https://bugs.webkit.org/show_bug.cgi?id=108678

Attachment 186116: Patch
https://bugs.webkit.org/attachment.cgi?id=186116&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186116&action=review


TJ: could you test one thing: instead of doing all this, could you not pass
HitTestRequest::IgnoreClipping to requestType? and see if it helps

> Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:463
>      getPaddings(topPadding, rightPadding, bottomPadding, leftPadding);
>  
> +    // Do not allow fat fingers detect anything not visible(ie outside of
the viewport)
> +    adjustPaddings(contentViewportPos, topPadding, rightPadding,
bottomPadding, leftPadding);

not better to have a getAdjustedPaddings? (merge both methods)


More information about the webkit-reviews mailing list