[webkit-reviews] review granted: [Bug 108431] webdatabase: Clean up calls to DatabaseTracker::add/removeOpenDatabase() : [Attachment 185935] the patch plus fixing up the chromium port to work with this change.

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 108431: webdatabase: Clean up calls to
DatabaseTracker::add/removeOpenDatabase()
https://bugs.webkit.org/show_bug.cgi?id=108431

Attachment 185935: the patch plus fixing up the chromium port to work with this
change.
https://bugs.webkit.org/attachment.cgi?id=185935&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185935&action=review


r=me 

esp with the attempt to address Michael's feedback that you mentioned.

> Source/WebCore/Modules/webdatabase/DatabaseBackend.cpp:297
> +#endif

Maybe the if could go away here if ExceptionCode were passed in? (Or if that is
a layering violation and it may be... then "m_ec == INVALID_STATE_ERR"
converted to an enum and passed into doneCreatingDatabase which could call
"DatabaseTracker::tracker().failedToOpenDatabase" when appropriate in the
chromium impl.


Just an idea.