[webkit-reviews] review granted: [Bug 108615] [Soup] Wrap SoupSession by NetworkStorageSession : [Attachment 186080] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 108615: [Soup] Wrap SoupSession by NetworkStorageSession
https://bugs.webkit.org/show_bug.cgi?id=108615

Attachment 186080: Patch
https://bugs.webkit.org/attachment.cgi?id=186080&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186080&action=review


Cool!

> Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:2
> + * Copyright (C) 2013 Apple Computer, Inc.  All rights reserved.

Did the Mac version say "Apple Computer"? The correct name is "Apple Inc."

> Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:33
> +using namespace WebCore;

We normally don't put "using" into headers.