[webkit-reviews] review denied: [Bug 104885] AX: should be able to use aria-label on an iframe for the AXTitle : [Attachment 179216] patch

Fri Feb 1 09:24:06 PST 2013

chris fleizach <cfleizach at apple.com> has denied chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 104885: AX: should be able to use aria-label on an iframe for the AXTitle
https://bugs.webkit.org/show_bug.cgi?id=104885

Attachment 179216: patch
https://bugs.webkit.org/attachment.cgi?id=179216&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=179216&action=review

>> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1312
>> +		const AtomicString& title =
documentObject->getAttribute(titleAttr);
> 
> If you called helpText, it would get the iframe's description from the
'title' attribute, but also from aria-describedby or from help text on
ancestors. Is that perhaps a good idea? It'd make things more consistent.

actually i realized we can just have a helpTextForWebArea type function and let
the normal platform mechanisms make the decision like they do for every other
element. this will then get the expected helpText() out for a web area so that
it matches other elements

>> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1334
>> +		return nameAttribute;
> 
> Why don’t we check this condition in the earlier if?

I believe because the name attribute on <html> is not valid (i could be wrong
on that)