[webkit-reviews] review denied: [Bug 108641] [TexMap] Backing store paints all tiles : [Attachment 186056] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 1 08:37:05 PST 2013

Noam Rosenthal <noam at webkit.org> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 108641: [TexMap] Backing store paints all tiles

Attachment 186056: Patch

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186056&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp:144
> +    GraphicsContext* context = textureMapper->graphicsContext();
> +    if (!context)
> +	   return;

I don't like relying on textureMapper->graphicsContext() here. It's not assured
that we're going to have that.
Instead, TextureMapper should have a clipBounds function and abstract it away
internally; E.g. TextureMapperGL has its own clip bounds based on the

More information about the webkit-reviews mailing list