[webkit-reviews] review denied: [Bug 108005] [GTK][WK2] MiniBrowser fullscreen signals support : [Attachment 186002] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 1 04:04:09 PST 2013

Carlos Garcia Campos <cgarcia at igalia.com> has denied Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 108005: [GTK][WK2] MiniBrowser fullscreen signals support

Attachment 186002: Patch

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=186002&action=review

Looks much better, there are still a few minor issues. You should also check in
the window fialize if there's a hide message callback scheduled and remove the
source in that case, otherwise the callback might be called with a window
already destroyed.

> Tools/MiniBrowser/gtk/BrowserWindow.c:271
> +    gtk_widget_hide(fullScreenMessageLabel);

Here you still need to set the fullScreenMessageLabelId to 0 again, so pass the
BrowserWindow instead of the label to the callback.

> Tools/MiniBrowser/gtk/BrowserWindow.c:279
> +    gchar *titleOrUri = webkit_web_view_get_title(window->webView);

This should be const, and the name titleOrURI

More information about the webkit-reviews mailing list