[webkit-reviews] review granted: [Bug 108596] AX: when aria-activedescendant is used with a ComboBox role, focus should not be changed : [Attachment 185973] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 1 01:15:17 PST 2013


Ryosuke Niwa <rniwa at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 108596: AX: when aria-activedescendant is used with a ComboBox role, focus
should not be changed
https://bugs.webkit.org/show_bug.cgi?id=108596

Attachment 185973: patch
https://bugs.webkit.org/attachment.cgi?id=185973&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185973&action=review


>
LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications.
html:21
> +	   window.jsTestIsAsync = true;
> +	   window.testRunner.waitUntilDone();

You don't need "window.".

>
LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications-
expected.txt:2
> +item1

Could you hide this before the test finishes so that the expected result will
have less noise?

>
LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications-
expected.txt:9
> +PASS combo.isEqual(accessibilityController.focusedElement) is true
> +PASS combo.isEqual(accessibilityController.focusedElement) is true

It's not obvious to me what has been tested. It would have been better if
comments in the tests were inside debug or they were wrapped in some inline
functions, which are then called in evalAndLog.


More information about the webkit-reviews mailing list