[webkit-reviews] review granted: [Bug 126316] Stop using ThreadCondition in JSC : [Attachment 220139] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 30 19:28:25 PST 2013


Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 126316: Stop using ThreadCondition in JSC
https://bugs.webkit.org/show_bug.cgi?id=126316

Attachment 220139: Patch
https://bugs.webkit.org/attachment.cgi?id=220139&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220139&action=review


> Source/JavaScriptCore/dfg/DFGWorklist.h:77
> -    void dump(const MutexLocker&, PrintStream&) const;
> +    void dump(const std::unique_lock<std::mutex>&, PrintStream&) const;

This should be a guard_lock<> as it makes it impossible get wrong.


More information about the webkit-reviews mailing list