[webkit-reviews] review granted: [Bug 126297] [GTK] Make the output directory of GObject unit tests binaries consistent with the CMake build : [Attachment 220120] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 126297: [GTK] Make the output directory of GObject unit tests binaries
consistent with the CMake build
https://bugs.webkit.org/show_bug.cgi?id=126297

Attachment 220120: Patch
https://bugs.webkit.org/attachment.cgi?id=220120&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220120&action=review


Looks good! Just a small suggestion:

> Tools/Scripts/run-gtk-tests:362
> -	   if "unittests" in test_program or "WebKit2APITests" in test_program:

> +	   if "WebKit1GObjectAPITest" in test_program or
"WebKit2GObjectAPITest" in test_program:

Perhaps simplify to if 'GObjectAPITest' in test_program ?