[webkit-reviews] review granted: [Bug 126285] XML document builder should create render tree asynchronously : [Attachment 220101] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 126285: XML document builder should create render tree asynchronously
https://bugs.webkit.org/show_bug.cgi?id=126285

Attachment 220101: patch
https://bugs.webkit.org/attachment.cgi?id=220101&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220101&action=review


r=me

> Source/WebCore/ChangeLog:19
> +	       recalc don't start creating new renderers.

doesn't

> Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:-1035
>      RefPtr<CDATASection> newNode =
CDATASection::create(m_currentNode->document(), toString(s, len));
>      m_currentNode->parserAppendChild(newNode.get());
> -    if (m_view)
> -	   Style::attachTextRenderer(*newNode);

We don't need to keep 'newNode' valid after appending it anymore, should make
it:
m_currentNode->parserAppendChild(newNode.release());