[webkit-reviews] review granted: [Bug 126278] Pending revision popover is slightly misplaced at build.webkit.org/dashboard : [Attachment 220089] oops, fix both branches

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 126278: Pending revision popover is slightly misplaced at
build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=126278

Attachment 220089: oops, fix both branches
https://bugs.webkit.org/attachment.cgi?id=220089&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220089&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/B
uildbotQueueView.js:97
> +		   var messageText = openSourceRevisionsBehind + " \uff0b " +
internalRevisionsBehind + " revisions behind";

Seeing "1 + 1 revisions behind" is kind of confusing. Maybe it should just be:
Math.max(openSourceRevisionsBehind, internalRevisionsBehind) + " revisions
behind"; Given that it will update both internal and open source in sync.