[webkit-reviews] review granted: [Bug 126131] [GTK] Downloads are broken with the network process enabled : [Attachment 220056] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 27 16:43:35 PST 2013
Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 126131: [GTK] Downloads are broken with the network process enabled
https://bugs.webkit.org/show_bug.cgi?id=126131
Attachment 220056: Patch
https://bugs.webkit.org/attachment.cgi?id=220056&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220056&action=review
> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:729
> if (d->client()->usesAsyncCallbacks())
> handle->client()->didReceiveResponseAsync(handle.get(),
d->m_response);
> - else
> + else {
> handle->client()->didReceiveResponse(handle.get(), d->m_response);
> + continueAfterDidReceiveResponse(handle.get());
> + }
Early return here maybe?
More information about the webkit-reviews
mailing list