[webkit-reviews] review granted: [Bug 126214] Merge PageVisibilityState & ViewState::IsVisible in WebKit2 : [Attachment 220022] Stupid autocorrect :-( ... s/pretender/prerender/ in Changelog

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 126214: Merge PageVisibilityState & ViewState::IsVisible in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=126214

Attachment 220022: Stupid autocorrect :-( ... s/pretender/prerender/ in
Changelog
https://bugs.webkit.org/attachment.cgi?id=220022&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220022&action=review


> Source/WebCore/ChangeLog:20
> +	   by the browser). The one aspect of the API relied on by existing
clients is the ability to
> +	   initialize a hidden view as prerender -continue to support this
specific functionality via

Seems like there should be a space in "-continue".

> Source/WebCore/ChangeLog:23
> +
> +

Extra blank line.

> Source/WebCore/ChangeLog:24
> +	   WebCore - chnages the the API tests exposed a bug, a view should
only ever come out of the

chnages, the the

> Source/WebKit2/ChangeLog:20
> +	   initialize a hidden view as prerender -continue to support this
specific functionality via

-continue

> Source/WebKit2/ChangeLog:23
> +
> +

Extra blank line.

> Tools/ChangeLog:23
> +	   initialize a hidden view as prerender -continue to support this
specific functionality via
> +	   WKPageSetVisibilityState, to maintain backwards compatibility.
> +
> +

...

Does this really need to be repeated in every ChangeLog? I usually put extra
info into a project that had the most changes - they are all combined for
commit message anyway.

> Tools/WebKitTestRunner/mac/TestControllerMac.mm:90
> +	   [window makeKeyAndOrderFront:nil];

Hopefully it's not forced back on screen, so nothing visually blinks and
prevents using the computer while tests are running?

> Tools/WebKitTestRunner/mac/TestControllerMac.mm:91
> +	   [NSApp activateIgnoringOtherApps:YES];

Why is this needed? A comment would probably be of use.