[webkit-reviews] review granted: [Bug 118944] [GTK] Add WebGL support under Wayland : [Attachment 219171] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 26 09:48:13 PST 2013
Alejandro G. Castro <alex at igalia.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 118944: [GTK] Add WebGL support under Wayland
https://bugs.webkit.org/show_bug.cgi?id=118944
Attachment 219171: Patch
https://bugs.webkit.org/attachment.cgi?id=219171&action=review
------- Additional Comments from Alejandro G. Castro <alex at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219171&action=review
LGTM, just added a small suggestion. Thanks for the patch.
> Source/WebCore/platform/graphics/GLContext.cpp:152
> +#if PLATFORM(NIX)
> + return nullptr;
> +#else
I think we could just: #if !PLATFORM(NIX), if we leave the last return nullptr
in the method outside of the ifdef.
More information about the webkit-reviews
mailing list