[webkit-reviews] review granted: [Bug 126230] [Nix] Adding createDragImageIconForCachedImageFilename method to DragImageNix : [Attachment 219996] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 25 15:45:07 PST 2013


Daniel Bates <dbates at webkit.org> has granted Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 126230: [Nix] Adding createDragImageIconForCachedImageFilename method to
DragImageNix
https://bugs.webkit.org/show_bug.cgi?id=126230

Attachment 219996: Patch
https://bugs.webkit.org/attachment.cgi?id=219996&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219996&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests needed.

Either remove this line or explain why "no new tests [are] needed". It seems
obvious that no new tests are needed as this patch is adding a function that is
materially consistent with an empty function.

> Source/WebCore/platform/nix/DragImageNix.cpp:73
> +    return 0;

Nit: 0 => nullptr


More information about the webkit-reviews mailing list