[webkit-reviews] review granted: [Bug 126229] [Nix] Fixing DragData::asFragment signature in DragDataNix.cpp : [Attachment 219995] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 25 15:41:21 PST 2013
Daniel Bates <dbates at webkit.org> has granted Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 126229: [Nix] Fixing DragData::asFragment signature in DragDataNix.cpp
https://bugs.webkit.org/show_bug.cgi?id=126229
Attachment 219995: Patch
https://bugs.webkit.org/attachment.cgi?id=219995&action=review
------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219995&action=review
> Source/WebCore/ChangeLog:8
> + No new tests needed.
Either remove this line or explain why "no new tests [are] needed". It seems
obvious that no new tests are needed as this patch is a build fix.
> Source/WebCore/platform/nix/DragDataNix.cpp:90
> return 0;
Nit: 0 => nullptr
More information about the webkit-reviews
mailing list