[webkit-reviews] review granted: [Bug 126196] Add the pseudo classes link and any-link to the Selector Code Generator : [Attachment 219949] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 126196: Add the pseudo classes link and any-link to the Selector Code
Generator
https://bugs.webkit.org/show_bug.cgi?id=126196

Attachment 219949: Patch
https://bugs.webkit.org/attachment.cgi?id=219949&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219949&action=review


> Source/WebCore/dom/Node.h:566
>      static ptrdiff_t nodeFlagsMemoryOffset() { return OBJECT_OFFSETOF(Node,
m_nodeFlags); }
> -    static uint8_t flagIsElement() { return IsElementFlag; }
> +    static int32_t flagIsElement() { return IsElementFlag; }
> +    static int32_t flagIsLink() { return IsLinkFlag; }

It's unfortunate that we have to expose flags... ideally we have some mechanism
to assert that the flag condition we're checking is consistent with Node's
implementation.