[webkit-reviews] review granted: [Bug 126189] Add the pseudo class :focus to the Selector Code Generator : [Attachment 219940] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 126189: Add the pseudo class :focus to the Selector Code Generator
https://bugs.webkit.org/show_bug.cgi?id=126189

Attachment 219940: Patch
https://bugs.webkit.org/attachment.cgi?id=219940&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219940&action=review


> Source/WebCore/cssjit/SelectorCompiler.cpp:244
> +	       m_functionType = std::max(m_functionType,
addPseudoType(selector->pseudoType(), fragment.pseudoClasses));

Maybe we should replace std::max with some descriptive inline function?
Or maybe addPseudoType should be a member function of SelectorCodeGenerator
that auto-updates m_functionType.
Or it should take m_functionType as an argument?