[webkit-reviews] review granted: [Bug 126176] Add class matching to the Selector Code Generator : [Attachment 219926] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 126176: Add class matching to the Selector Code Generator
https://bugs.webkit.org/show_bug.cgi?id=126176

Attachment 219926: Patch
https://bugs.webkit.org/attachment.cgi?id=219926&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=219926&action=review


It might be good if someone who knows the marcoassembler would also take a
look.

> Source/WebCore/cssjit/SelectorCompiler.cpp:209
> +    HashSet<const AtomicStringImpl*> fragmentClassNames;

Repeating class names are probably very rare. It may be better to just use a
vector and not care about removing duplicates.