[webkit-reviews] review granted: [Bug 116376] [GTK] [CMake] Add support for generating gtkdoc : [Attachment 219927] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 116376: [GTK] [CMake] Add support for generating gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=116376

Attachment 219927: Patch
https://bugs.webkit.org/attachment.cgi?id=219927&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219927&action=review


Thanks! A couple things to consider for landing...

> Source/PlatformGTK.cmake:1
> +set(GTK_DOCS_DEPENDENCIES

I have been using camel case for most CMake variables, so perhaps this could be
DocumentationDependencies instead of GTK_DOCS_DEPENDENCIES?

> Tools/gtk/common.py:33
> +    if type(is_cmake) is not bool:

is_cmake == None ?

> Tools/gtk/generate-gtkdoc:140
> +    source_dirs = [src_path('webkit')]
> +

Looks like this is unused now?