[webkit-reviews] review granted: [Bug 126173] [GTK][WK2] Simplify ProcessExecutablePathGtk : [Attachment 219923] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 126173: [GTK][WK2] Simplify ProcessExecutablePathGtk
https://bugs.webkit.org/show_bug.cgi?id=126173

Attachment 219923: Patch
https://bugs.webkit.org/attachment.cgi?id=219923&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219923&action=review


> Source/WebKit2/Shared/gtk/ProcessExecutablePathGtk.cpp:51
> +    static CString executablePath = getCurrentExecutablePath();
>      if (!executablePath.isNull()) {
> -	   String processPath = pathByAppendingComponent(executablePath,
processName);
> +	   String processPath =
pathByAppendingComponent(directoryName(filenameToString(executablePath.data()))
, processName);
>	   if (fileExists(processPath))
>	       return processPath;

This is a little slower, because directoryName and filenameToString runs for
each path, but not much.