[webkit-reviews] review granted: [Bug 126171] Update custom setter implementations to perform type checks : [Attachment 219920] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 23 11:47:51 PST 2013


Daniel Bates <dbates at webkit.org> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 126171: Update custom setter implementations to perform type checks
https://bugs.webkit.org/show_bug.cgi?id=126171

Attachment 219920: Patch
https://bugs.webkit.org/attachment.cgi?id=219920&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219920&action=review


This patch looks straightforward to me.

> Source/WebCore/ChangeLog:8
> +	   Update the bindings codegen for setters so that they perform a real

Nit: codegen => code generator

> Source/WebCore/ChangeLog:9
> +	   typecheck.

Nit: typecheck => type check


More information about the webkit-reviews mailing list