[webkit-reviews] review granted: [Bug 126141] cStack branch doesn't run navier-stokes : [Attachment 219918] the patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 126141: cStack branch doesn't run navier-stokes
https://bugs.webkit.org/show_bug.cgi?id=126141

Attachment 219918: the patch
https://bugs.webkit.org/attachment.cgi?id=219918&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219918&action=review


r=me with comments.

> Source/JavaScriptCore/jit/JITCall.cpp:147
> +    addPtr(TrustedImm32(-static_cast<ptrdiff_t>(sizeof(CallerFrameAndPC))),
stackPointerRegister, regT1);
>      emitGetFromCallFrameHeader64(JSStack::Callee, regT0, regT1);

Why don't you change this to a helper uses SP and takes into account the
CallerFrameAndPC bias?

> Source/JavaScriptCore/jit/JITCall.cpp:191
> +    } // SP holds newCallFrame with ArgumentCount initialized.

Change the comment to include that SP is offset by CallerFrameAndPC.