[webkit-reviews] review denied: [Bug 125683] [GTK] [CMake] Build the WebKit2 GObject API tests : [Attachment 219879] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 22 12:52:08 PST 2013


Gustavo Noronha (kov) <gns at gnome.org> has denied Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 125683: [GTK] [CMake] Build the WebKit2 GObject API tests
https://bugs.webkit.org/show_bug.cgi?id=125683

Attachment 219879: Patch
https://bugs.webkit.org/attachment.cgi?id=219879&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219879&action=review


hmm I'm confuse. This seems to also add the wk1 version of the GObject API
tests!

> Source/PlatformGTK.cmake:3
> +if (ENABLE_WEBKIT)
> +    add_subdirectory(${WEBKIT_DIR}/gtk/tests)
> +endif ()

This actually makes more sense than the patch I r+ed in the other bug heh.


More information about the webkit-reviews mailing list