[webkit-reviews] review granted: [Bug 125569] [GTK][CMake] Integrate GResource for inspector files (and others?) : [Attachment 219875] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 125569: [GTK][CMake] Integrate GResource for inspector files (and others?)
https://bugs.webkit.org/show_bug.cgi?id=125569

Attachment 219875: Patch
https://bugs.webkit.org/attachment.cgi?id=219875&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219875&action=review


> Source/WebInspectorUI/GNUmakefile.am:11
> +	$(AM_V_at)$(srcdir)/Tools/gtk/generate-inspector-gresource-manifest.py
$@

Nice =) maybe you should depend on the script as well.

> Source/WebKit2/GNUmakefile.am:27
>	$(AM_V_at)glib-compile-resources --generate
--sourcedir=$(WebKit2)/UIProcess/InspectorServer/front-end \
> -		--target=${GENSOURCES_WEBINSPECTOR_UI}/WebKit2GResourceBundle.c
${GENSOURCES_WEBINSPECTOR_UI}/WebKit2GResourceBundle.xml
> -
> -BUILT_SOURCES += \
> -	DerivedSources/WebInspectorUI/WebKit2GResourceBundle.xml
> +		--target=${GENSOURCES_WEBINSPECTOR_UI}/WebKit2GResourceBundle.c
$(WebKit2)/UIProcess/API/gtk/WebKit2InspectorGResourceBundle.xml

Makes so much more sense. Why did I add that many echo calls instead of
shipping this file I know not.