[webkit-reviews] review denied: [Bug 123567] ASSERTION FAILED: isEditablePosition(*this) in WebCore::Position::leadingWhitespacePosition : [Attachment 219842] patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Gergő Balogh
<geryxyz at inf.u-szeged.hu>'s request for review:
Bug 123567: ASSERTION FAILED: isEditablePosition(*this) in
WebCore::Position::leadingWhitespacePosition
https://bugs.webkit.org/show_bug.cgi?id=123567

Attachment 219842: patch
https://bugs.webkit.org/attachment.cgi?id=219842&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219842&action=review


> Source/WebCore/editing/EditorCommand.cpp:196
> +    if (!frame.selection().isContentEditable())
> +	   return false;

r-. This is not the right place to check this condition. enabledInEditableText
should already be checking this condition.