[webkit-reviews] review granted: [Bug 126118] Figure out if node is focusable without requiring renderer : [Attachment 219850] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Dec 21 07:09:44 PST 2013
Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 126118: Figure out if node is focusable without requiring renderer
https://bugs.webkit.org/show_bug.cgi?id=126118
Attachment 219850: patch
https://bugs.webkit.org/attachment.cgi?id=219850&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219850&action=review
This seems like a pretty good solution. r=me.
> Source/WebCore/dom/Node.cpp:566
> + if (!document().renderView())
> + return false;
How about checking !Document::hasLivingRenderTree() here instead?
More information about the webkit-reviews
mailing list