[webkit-reviews] review denied: [Bug 108184] ASSERT(time.isFinite()) in SVGSMILElement::createInstanceTimesFromSyncbase : [Attachment 219638] patch, 1st try

[bugzilla-daemon at webkit.org]

Philip Rogers <pdr at google.com> has denied Tamas Gergely
<tgergely.u-szeged at partner.samsung.com>'s request for review:
Bug 108184: ASSERT(time.isFinite()) in
SVGSMILElement::createInstanceTimesFromSyncbase
https://bugs.webkit.org/show_bug.cgi?id=108184

Attachment 219638: patch, 1st try
https://bugs.webkit.org/attachment.cgi?id=219638&action=review

------- Additional Comments from Philip Rogers <pdr at google.com>
I don't think this is the right approach because it will break valid self
references. For example:
<rect width="100" height="100" fill="green">
  <animate id="fri" attributeName="x" begin="0s; fri.end + 3s" from="0"
to="400" dur="5s"/>
</rect>

I think we probably need to remove the assertion and not call
addBeginTime/addEndTime if the time is not finite.