[webkit-reviews] review granted: [Bug 126006] [SOUP] ResourceHandleSoup should use async client callbacks when client uses async callbacks : [Attachment 219671] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 20 11:17:29 PST 2013


Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 126006: [SOUP] ResourceHandleSoup should use async client callbacks when
client uses async callbacks
https://bugs.webkit.org/show_bug.cgi?id=126006

Attachment 219671: Patch
https://bugs.webkit.org/attachment.cgi?id=219671&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
Looks good, but as you suggested I think we should add FIXMEs to actually
implement the asynchronous versions of these methods. It would also be good to
open a bug for this and include the bug URL in the FIXME. That way this won't
get lost in the cracks.


More information about the webkit-reviews mailing list