[webkit-reviews] review denied: [Bug 126057] Clearing 'dir' attribute does not correctly set page directionality : [Attachment 219738] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Prashant Hiremath
<hiremathprashants at gmail.com>'s request for review:
Bug 126057: Clearing 'dir' attribute does not correctly set page directionality
https://bugs.webkit.org/show_bug.cgi?id=126057

Attachment 219738: Patch
https://bugs.webkit.org/attachment.cgi?id=219738&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219738&action=review


> Source/WebCore/html/HTMLElement.cpp:209
> +	       AtomicString dirValue = isValidDirAttribute(value) ? value :
"ltr";

This is incorrect. When dir="" attribute doesn't parse correctly, it needs to
be treated as if it doesn't exist for the purpose of determining the
directionality of text.
I've specifically added a test case for this in
fast/dom/HTMLElement/set-and-clear-dir-attribute.html

i.e. the blink change is wrong.