[webkit-reviews] review granted: [Bug 126054] REGRESSION: cnn.com will continue to reveal 1 px of overhang after rubber-banding at the top : [Attachment 219731] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 19 22:46:44 PST 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 126054: REGRESSION: cnn.com will continue to reveal 1 px of overhang after
rubber-banding at the top
https://bugs.webkit.org/show_bug.cgi?id=126054

Attachment 219731: Patch
https://bugs.webkit.org/attachment.cgi?id=219731&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219731&action=review


> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:287
> +    float nearestXWithinBounds =
std::max<float>(std::min<float>(currentScrollPosition.x(), maxPosition.x()),
minPosition.x());
> +    float nearestYWithinBounds =
std::max<float>(std::min<float>(currentScrollPosition.y(), maxPosition.y()),
minPosition.y());

Not sure why you're doing this in floats (yet).

> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:739
> +    bool currentlyConstrainsToContentEdge =
m_scrollableArea->constrainsScrollingToContentEdge();
> +    m_scrollableArea->setConstrainsScrollingToContentEdge(true);

We can't use TemporaryChange<> here?


More information about the webkit-reviews mailing list