[webkit-reviews] review granted: [Bug 126042] Clarify the behavior of composited canvases : [Attachment 219718] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 126042: Clarify the behavior of composited canvases
https://bugs.webkit.org/show_bug.cgi?id=126042

Attachment 219718: Patch
https://bugs.webkit.org/attachment.cgi?id=219718&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219718&action=review


> Source/WebCore/rendering/RenderLayerBacking.cpp:88
>  #if ENABLE(WEBGL) || ENABLE(ACCELERATED_2D_CANVAS)

This #if needs to have a case for IOSurface-backed canvas too, otherwise if
PLATFORM(MAC) were to compile WebGL out we'd always be returning
UnacceleratedCanvas.

Or like you mentioned on IRC you might not need them at all.