[webkit-reviews] review requested: [Bug 126018] Web Inspector: Uncaught Exception: NavigationSidebarPanel.js: ERROR: TypeError: undefined is not a function (evaluating 'representedObject.saveIdentityToCookie(candidateObjectCookie)') : [Attachment 219706] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 19 17:03:27 PST 2013
Joseph Pecoraro <joepeck at webkit.org> has asked for review:
Bug 126018: Web Inspector: Uncaught Exception: NavigationSidebarPanel.js:
ERROR: TypeError: undefined is not a function (evaluating
'representedObject.saveIdentityToCookie(candidateObjectCookie)')
https://bugs.webkit.org/show_bug.cgi?id=126018
Attachment 219706: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=219706&action=review
------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
On IRC the feedback was we should still be resilient against a missing
representedObject.saveIdentityToCookie. So I added the if check, and
console.error warn if it didn't exist.
More information about the webkit-reviews
mailing list