[webkit-reviews] review denied: [Bug 126004] Implement ArrayBuffer.isView : [Attachment 219690] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 126004: Implement ArrayBuffer.isView
https://bugs.webkit.org/show_bug.cgi?id=126004

Attachment 219690: Patch
https://bugs.webkit.org/attachment.cgi?id=219690&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219690&action=review


Almost there :)

> Source/JavaScriptCore/runtime/JSArrayBufferConstructor.cpp:56
> +    putDirectNativeFunction(vm, globalObject(), makeIdentifier(vm,
("isView")), 1, arrayBufferFuncIsView, NoIntrinsic, DontEnum |Function);

JSC_NATIVE_FUNCTION(vm.propertyNames->isView, arrayBufferFuncIsView, DontEnum,
1);

Add isView to CommonIdentifiers