[webkit-reviews] review granted: [Bug 125985] Test that text-decoration-skip: ink is the same as regular underlines if no descenders : [Attachment 219630] Patch

Thu Dec 19 14:56:30 PST 2013

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 125985: Test that text-decoration-skip: ink is the same as regular
underlines if no descenders
https://bugs.webkit.org/show_bug.cgi?id=125985

Attachment 219630: Patch
https://bugs.webkit.org/attachment.cgi?id=219630&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219630&action=review

>
LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decor
ation-skip-ink-no-descenders-expected.html:1
> +<!DOCTYPE HTML>

Minor preference for <!DOCTYPE html>

>
LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decor
ation-skip-ink-no-descenders-expected.html:8
> +<div style="display: inline-block; -webkit-transform: scale(5);
-webkit-transform-origin: left top; -webkit-text-decoration-line: underline">NO
DESCENDERS</div>

Please use text-decoration: underline

>
LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decor
ation-skip-ink-no-descenders.html:8
> +<div style="display: inline-block; -webkit-text-decoration-skip: ink;
-webkit-transform: scale(5); -webkit-transform-origin: left top;
-webkit-text-decoration-line: underline">NO DESCENDERS</div>

Ditto.