[webkit-reviews] review denied: [Bug 125958] Final preparations for GStreamer on Windows : [Attachment 219619] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Alex Christensen
<alex.christensen at flexsim.com>'s request for review:
Bug 125958: Final preparations for GStreamer on Windows
https://bugs.webkit.org/show_bug.cgi?id=125958

Attachment 219619: Patch
https://bugs.webkit.org/attachment.cgi?id=219619&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219619&action=review


Please use the $(WebKit_Libraries) variable instead of the relative paths.

> Source/WTF/WTF.vcxproj/WTFDebugWinCairo.props:9
> +    <Import
Project="..\..\..\WebKitLibraries\win\tools\vsprops\WinCairo.props" />

This should be "$(WebKit_Libraries)\tools\..."

> Source/WTF/WTF.vcxproj/WTFReleaseWinCairo.props:9
> +    <Import
Project="..\..\..\WebKitLibraries\win\tools\vsprops\WinCairo.props" />

Ditto.

> Source/WTF/wtf/Platform.h:908
> +#define WTF_USE_GLIB 1

:-(