[webkit-reviews] review denied: [Bug 125988] Precede boolean values with words like "is" and "did". : [Attachment 219641] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 19 07:23:33 PST 2013
Darin Adler <darin at apple.com> has denied Gergő Balogh
<geryxyz at inf.u-szeged.hu>'s request for review:
Bug 125988: Precede boolean values with words like "is" and "did".
https://bugs.webkit.org/show_bug.cgi?id=125988
Attachment 219641: patch
https://bugs.webkit.org/attachment.cgi?id=219641&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
This doesn’t seem like something the style checker can correctly check without
linguistic analysis. For example, "requiresHeader" is a perfectly good name for
a boolean. And "isRequiresHeader" is bad.
More information about the webkit-reviews
mailing list