[webkit-reviews] review granted: [Bug 125964] CStack Branch: Stop threading callFrameRegister through LLIntSlowCalls : [Attachment 219595] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 125964: CStack Branch: Stop threading callFrameRegister through
LLIntSlowCalls
https://bugs.webkit.org/show_bug.cgi?id=125964

Attachment 219595: Patch
https://bugs.webkit.org/attachment.cgi?id=219595&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219595&action=review


r=me

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:804
>      callSlowPath(_llint_slow_path_size_and_alloc_frame_for_varargs)
>      branchIfException(_llint_throw_from_slow_path_trampoline)
> -    loadp CodeBlock[cfr], t0
> -    loadp CodeBlock::m_vm[t0], t0
> -    loadp VM::newCallFrameReturnValue[t0], t0
> -    move t0, sp
> +    # calleeFrame in t1
> +    move t1, sp

Is it valid for _llint_slow_path_size_and_alloc_frame_for_varargs to allocate
calleeFrame like this?