[webkit-reviews] review granted: [Bug 125959] [Cocoa] Allow the web process plug-in to intercept resource requests : [Attachment 219580] Add -webProcessPlugInBrowserContextController:frame:willSendRequest:redirectResponse:

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 18 16:36:38 PST 2013


Anders Carlsson <andersca at apple.com> has granted mitz at webkit.org
<mitz at webkit.org>'s request for review:
Bug 125959: [Cocoa] Allow the web process plug-in to intercept resource
requests
https://bugs.webkit.org/show_bug.cgi?id=125959

Attachment 219580: Add
-webProcessPlugInBrowserContextController:frame:willSendRequest:redirectRespons
e:
https://bugs.webkit.org/attachment.cgi?id=219580&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219580&action=review


>
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserConte
xtController.mm:144
> +    if (loadDelegate) {
>	   setUpPageLoaderClient(self, *_page);
> -    else
> +	   setUpResourceLoadClient(self, *_page);

I'd use an early return here to get rid of the ugly one-liner inside the brace.


More information about the webkit-reviews mailing list