[webkit-reviews] review granted: [Bug 125213] CSS: Add a property cascading pass to style application. : [Attachment 219579] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 125213: CSS: Add a property cascading pass to style application.
https://bugs.webkit.org/show_bug.cgi?id=125213

Attachment 219579: Patch
https://bugs.webkit.org/attachment.cgi?id=219579&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=219579&action=review


very cool!

> Source/WebCore/css/StyleResolver.cpp:195
> +class StyleResolver::CascadedProperties {
> +public:

I would moved this where it is defined and used.

> Source/WebCore/css/StyleResolver.cpp:1774
> +	       const auto& property =
matchedProperties.properties->propertyAt(i);

...

> Source/WebCore/css/StyleResolver.cpp:4251
> +	   StyleProperties::PropertyReference current =
properties.propertyAt(i);

... consistency would be nicer. I guess just 'auto'