[webkit-reviews] review granted: [Bug 125512] [GTK][CMake] make libjavascriptcoregtk a public shared library again : [Attachment 219574] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 125512: [GTK][CMake] make libjavascriptcoregtk a public shared library
again
https://bugs.webkit.org/show_bug.cgi?id=125512

Attachment 219574: Patch
https://bugs.webkit.org/attachment.cgi?id=219574&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219574&action=review


> Source/JavaScriptCore/CMakeLists.txt:765
> +get_target_property(TARGET_TYPE JavaScriptCore TYPE)
> +if (${TARGET_TYPE} STREQUAL "SHARED_LIBRARY")

I think you can just do:

if (${JavaScriptCore_LIBRARY_TYPE} STREQUAL "SHARED")

here and avoid the get_target_property call.