[webkit-reviews] review granted: [Bug 125941] Add Obj C API for injected bundle PageGroup class. : [Attachment 219566] Use _bundlePageGroup->identifier() directly, instead of going through WFStringRef wrapper.

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Yongjun Zhang
<yongjun_zhang at apple.com>'s request for review:
Bug 125941: Add Obj C API for injected bundle PageGroup class.
https://bugs.webkit.org/show_bug.cgi?id=125941

Attachment 219566: Use _bundlePageGroup->identifier() directly, instead of
going through WFStringRef wrapper.
https://bugs.webkit.org/attachment.cgi?id=219566&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219566&action=review


>
Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.
h:35
> +- (NSString *)identifier;

This is probably better expressed as @property (readonly) NSString *identifier;


>
Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.
mm:34
> +#import "WKAPICast.h"
> +#import "WKNSString.h"
> +#import "WKRetainPtr.h"

Probably don’t need these anymore.

>
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserConte
xtController.h:47
> + at property(readonly) WKWebProcessPlugInFrame *mainFrame;
> +
> + at property(readonly) WKWebProcessPlugInPageGroup *pageGroup;

There needs to be a space before the (, even though some existing code is
wrong.