[webkit-reviews] review granted: [Bug 125766] [GTK] [CMake] Add support for building GtkLauncher : [Attachment 219300] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 125766: [GTK] [CMake] Add support for building GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=125766

Attachment 219300: Patch
https://bugs.webkit.org/attachment.cgi?id=219300&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219300&action=review


> Tools/GtkLauncher/CMakeLists.txt:1
> +add_definitions(-DWEBKIT_EXEC_PATH="${CMAKE_RUNTIME_OUTPUT_DIRECTORY}")

I guess this is OK since we won't install GtkLauncher, right?

> Tools/GtkLauncher/main.c:28
> +#if defined(HAVE_CONFIG_H) && HAVE_CONFIG_H

I take it this is also the case with autotools, right? I think so, but… =)