[webkit-reviews] review granted: [Bug 116377] [GTK] [CMake] Add support for building WebKit1 : [Attachment 219299] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 116377: [GTK] [CMake] Add support for building WebKit1
https://bugs.webkit.org/show_bug.cgi?id=116377

Attachment 219299: Patch
https://bugs.webkit.org/attachment.cgi?id=219299&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219299&action=review


> Source/WebKit/gtk/GNUmakefile.am:362
> +	$(AM_V_GEN)glib-mkenums --template
$(srcdir)/Source/WebKit/gtk/webkit/webkitenumtypes.h.template
$(webkitgtk_h_api) | \

Much nicer =)

> ChangeLog:10
> +	   * Source/cmake/OptionsGTK.cmake: Turn off some features that do not
build properly
> +	   for WebKit1 and stop using the version script which we haven't
implemented yet. Turn
> +	   on WebKit1.

The version script was not actually being used, was it?