[webkit-reviews] review requested: [Bug 125915] False webkit-check-style warnings on * : [Attachment 219533] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 18 07:02:37 PST 2013
Gergő Balogh <geryxyz at inf.u-szeged.hu> has asked for review:
Bug 125915: False webkit-check-style warnings on *
https://bugs.webkit.org/show_bug.cgi?id=125915
Attachment 219533: patch
https://bugs.webkit.org/attachment.cgi?id=219533&action=review
------- Additional Comments from Gergő Balogh <geryxyz at inf.u-szeged.hu>
I fix this error.
However keep in mind there is impossible (without a full-parser) to distinguish
the following to scenarios.
pointer declaration:
<some type> * <some variable name>;
multiplication:
<some variable name> * <some (other) variable name>;
Of course the latest one is bad practice. So I only filter the case:
delete <variable name> * <variable name>;
return <variable name> * <variable name>;
More information about the webkit-reviews
mailing list