[webkit-reviews] review granted: [Bug 125924] Null-pointer dereference in WebCore::RootInlineBox::prevRootBox : [Attachment 219529] Proposed patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Dániel Bátyai
<dbatyai.u-szeged at partner.samsung.com>'s request for review:
Bug 125924: Null-pointer dereference in WebCore::RootInlineBox::prevRootBox
https://bugs.webkit.org/show_bug.cgi?id=125924

Attachment 219529: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=219529&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219529&action=review


Code change looks fine, but we need to remove the "nobreak" comment.

> LayoutTests/ChangeLog:3
> +	   Null-pointer dereference in WebCore::RootInlineBox::prevRootBox

This is a bad bug/patch title and we should avoid them. It describes the
symptom and not the cause.
I would call it something like "CSS: Null-pointer dereference with negative
'orphans' value."

> Source/WebCore/css/CSSParser.cpp:2225
>	   /* nobreak */

This idiosyncratic comment is no longer valid since you're removing the
fall-through.