[webkit-reviews] review granted: [Bug 125785] Additional refinement in MathMLSelectElement toggle implementation : [Attachment 219326] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 18 02:20:06 PST 2013


Andreas Kling <akling at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 125785: Additional refinement in MathMLSelectElement toggle implementation
https://bugs.webkit.org/show_bug.cgi?id=125785

Attachment 219326: Patch
https://bugs.webkit.org/attachment.cgi?id=219326&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219326&action=review


r=me

>> Source/WebCore/mathml/MathMLSelectElement.cpp:161
>>	// This will also call MathMLSelectElement::attributeChanged to update
the selected child.
> 
> I should probably cut down this comment, too. It spends too many words
restating exactly what the code below says, and should limit itself to the
non-obvious part.

Your choice. Leaving cq? set.


More information about the webkit-reviews mailing list