[webkit-reviews] review granted: [Bug 125908] Add a simple stack abstraction for x86_64 : [Attachment 219503] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 125908: Add a simple stack abstraction for x86_64
https://bugs.webkit.org/show_bug.cgi?id=125908

Attachment 219503: Patch
https://bugs.webkit.org/attachment.cgi?id=219503&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219503&action=review


r=me

> Source/JavaScriptCore/ChangeLog:11
> +	   Add an explicit abstraction for the "lea" instruction. This is
needed
> +	   by the experimental JIT to have add and substract without changing
the flags.

Why do we need to avoid changing flags before a call? Would be good to explain
that.

> Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h:231
> +#if ENABLE(CSS_SELECTOR_JIT)

No need for the #if.

> Source/WebCore/cssjit/StackAllocator.h:112
> +    void combine(StackAllocator&& stackA, StackAllocator&& stackB)

I think the typical compiler word for this is "merge".