[webkit-reviews] review granted: [Bug 125872] DatabaseProcess: Pipe through object store IDs and transaction mode for "openTransaction" : [Attachment 219452] Patch v1

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 125872: DatabaseProcess: Pipe through object store IDs and transaction mode
for "openTransaction"
https://bugs.webkit.org/show_bug.cgi?id=125872

Attachment 219452: Patch v1
https://bugs.webkit.org/attachment.cgi?id=219452&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219452&action=review


> Source/WebCore/Modules/indexeddb/IndexedDB.h:41
>  enum TransactionMode {
> +    TransactionModeMinimum = 0,
>      TransactionReadOnly = 0,
>      TransactionReadWrite = 1,
> -    TransactionVersionChange = 2
> +    TransactionVersionChange = 2,
> +    TransactionModeMaximum = 2,
>  };

I'd use an enum class now:

enum class TransactionMode {
    ReadOnly = 0,
    ReadWrite = 1
    VersionChange = 2,
};
const unsigned maximumTransactionMode = 2;

(not sure why the minimum can't just be assumed 0).